Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ambiguity_threshold param to FallbackClassifier #6355

Merged
merged 4 commits into from
Aug 10, 2020
Merged

add ambiguity_threshold param to FallbackClassifier #6355

merged 4 commits into from
Aug 10, 2020

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Aug 6, 2020 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation (part of rule policy documentation #6195)
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested review from tabergma, chkoss and alwx and removed request for tabergma and chkoss August 6, 2020 13:35
tabergma
tabergma approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

rasa/nlu/classifiers/fallback_classifier.py Outdated Show resolved Hide resolved
rasa/nlu/classifiers/fallback_classifier.py Outdated Show resolved Hide resolved
rasa/nlu/classifiers/fallback_classifier.py Outdated Show resolved Hide resolved
@wochinge wochinge removed the request for review from alwx August 10, 2020 09:39
@wochinge wochinge force-pushed the fallback-classifier-disambiguate branch from a5d937e to c958b0d Compare August 10, 2020 10:11
@wochinge wochinge force-pushed the fallback-classifier-disambiguate branch from c958b0d to df8fe8c Compare August 10, 2020 10:12
@rasabot rasabot merged commit 3e781a9 into master Aug 10, 2020
@rasabot rasabot deleted the fallback-classifier-disambiguate branch August 10, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RulePolicy: FallbackClassifier should have parameter ambiguity_threshold
3 participants
@wochinge @tabergma @rasabot